[webview_flutter] Disable unnecessary web-engine initialization #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewk_init() and ewk_shutdown() are designed to be called only once in a process. (If ewk_init() is called after ewk_shutdown() is called, SIGTRAP is called internally.) ewk_init() initializes the efl module and web engine's arguments data. The efl module is initialized by default in OS, and Arguments data is also initialized through SetArguments() API, so calling ewk_init() is not necessary. Therefore, temporarily comment out ewk_init() and ewk_shutdown(). It can be reverted depending on updates to chromium-efl. ewk_init();
|
there is another option JSUYA@ae22374 |
xiaowei-guan
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ewk_init() and ewk_shutdown() are designed to be called only once in a process.
(If ewk_init() is called after ewk_shutdown() is called, SIGTRAP is called internally.)
ewk_init() initializes the efl module and web engine's arguments data.
The efl module is initialized by default in OS, and Arguments data is also initialized
through SetArguments() API, so calling ewk_init() is not necessary.
Therefore, temporarily comment out ewk_init() and ewk_shutdown().
It can be reverted depending on updates to chromium-efl. ewk_init();
related issue: #697