Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[video_player_avplay] Updgrade plusplayer #714

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

xiaowei-guan
Copy link
Contributor

Main changes:

  • [HLS] Disabling playback rate change and reducing max latency threshold.
  • [HLS] Bitrate switching optimization and seek to live handling.
  • [DASH] Fixing LL-DASH live channel stuck issue.
  • [PLUSPLAYER] Fixing svace issue cast from int to uint64_t.
  • [DASH] Optimization for LL-DASH catch-up.
  • [HLS] Null check before dereferencing pointer.
  • [HLS] Fix Live stream getting stucked after 15-20 min.

@JSUYA
Copy link
Member

JSUYA commented Jul 26, 2024

Hi @xiaowei-guan
I tested example with 8.0 device. In HLS tab, When i clicked 90% ~ point of progressbar, video player is still stopped.
I tried waiting for buffering but the video player keeps freezing.
By comparing the sizes of the installed libhls.so, I was able to check that armel/8.0 lib was installed correctly.
(-rw-r--r-- 1 tizenglobalapp root 940106 Jul 26 16:00 libhls.so)
Could you please check again?

root@localhost:/opt/usr/apps/org.tizen.video_player_avplay_example/lib# ls -al
total 59464
drwxr-xr-x 1 tizenglobalapp root       23 Jul 26 16:00 .
drwxr-xr-x 1 tizenglobalapp root        7 Jul 26 16:01 ..
-rw-r--r-- 1 tizenglobalapp root  3652094 Jul 26 16:00 libavcodec_common.so
-rw-r--r-- 1 tizenglobalapp root   445530 Jul 26 16:00 libavformat_mmdash.so
-rw-r--r-- 1 tizenglobalapp root   503646 Jul 26 16:00 libavformat_mmhls.so
-rw-r--r-- 1 tizenglobalapp root   450426 Jul 26 16:00 libavformat_mmhttp.so
-rw-r--r-- 1 tizenglobalapp root   367778 Jul 26 16:00 libavutil_common.so
-rw-r--r-- 1 tizenglobalapp root  1235414 Jul 26 16:00 libdash.so
-rw-r--r-- 1 tizenglobalapp root   831354 Jul 26 16:00 libdashplusplayer_tvplus.so
-rw-r--r-- 1 tizenglobalapp root 34389752 Jul 26 16:00 libflutter_engine.so
-rw-r--r-- 1 tizenglobalapp root  3105892 Jul 26 16:00 libflutter_plugins.so
-rw-r--r-- 1 tizenglobalapp root   592568 Jul 26 16:00 libflutter_tizen.so
-rw-r--r-- 1 tizenglobalapp root   302398 Jul 26 16:00 libgstdash.so
-rw-r--r-- 1 tizenglobalapp root   349322 Jul 26 16:00 libgsthls.so
-rw-r--r-- 1 tizenglobalapp root    52014 Jul 26 16:00 libgsthttpdemux.so
-rw-r--r-- 1 tizenglobalapp root    76554 Jul 26 16:00 libgstmmhttpsrc.so
-rw-r--r-- 1 tizenglobalapp root    26718 Jul 26 16:00 libgstsubtitle_tvplus.so
-rw-r--r-- 1 tizenglobalapp root   153382 Jul 26 16:00 libgstsubtitleparse_tvplus.so
-rw-r--r-- 1 tizenglobalapp root   940106 Jul 26 16:00 libhls.so
......

@xiaowei-guan
Copy link
Contributor Author

Hi @xiaowei-guan I tested example with 8.0 device. In HLS tab, When i clicked 90% ~ point of progressbar, video player is still stopped. I tried waiting for buffering but the video player keeps freezing. By comparing the sizes of the installed libhls.so, I was able to check that armel/8.0 lib was installed correctly. (-rw-r--r-- 1 tizenglobalapp root 940106 Jul 26 16:00 libhls.so) Could you please check again?

root@localhost:/opt/usr/apps/org.tizen.video_player_avplay_example/lib# ls -al
total 59464
drwxr-xr-x 1 tizenglobalapp root       23 Jul 26 16:00 .
drwxr-xr-x 1 tizenglobalapp root        7 Jul 26 16:01 ..
-rw-r--r-- 1 tizenglobalapp root  3652094 Jul 26 16:00 libavcodec_common.so
-rw-r--r-- 1 tizenglobalapp root   445530 Jul 26 16:00 libavformat_mmdash.so
-rw-r--r-- 1 tizenglobalapp root   503646 Jul 26 16:00 libavformat_mmhls.so
-rw-r--r-- 1 tizenglobalapp root   450426 Jul 26 16:00 libavformat_mmhttp.so
-rw-r--r-- 1 tizenglobalapp root   367778 Jul 26 16:00 libavutil_common.so
-rw-r--r-- 1 tizenglobalapp root  1235414 Jul 26 16:00 libdash.so
-rw-r--r-- 1 tizenglobalapp root   831354 Jul 26 16:00 libdashplusplayer_tvplus.so
-rw-r--r-- 1 tizenglobalapp root 34389752 Jul 26 16:00 libflutter_engine.so
-rw-r--r-- 1 tizenglobalapp root  3105892 Jul 26 16:00 libflutter_plugins.so
-rw-r--r-- 1 tizenglobalapp root   592568 Jul 26 16:00 libflutter_tizen.so
-rw-r--r-- 1 tizenglobalapp root   302398 Jul 26 16:00 libgstdash.so
-rw-r--r-- 1 tizenglobalapp root   349322 Jul 26 16:00 libgsthls.so
-rw-r--r-- 1 tizenglobalapp root    52014 Jul 26 16:00 libgsthttpdemux.so
-rw-r--r-- 1 tizenglobalapp root    76554 Jul 26 16:00 libgstmmhttpsrc.so
-rw-r--r-- 1 tizenglobalapp root    26718 Jul 26 16:00 libgstsubtitle_tvplus.so
-rw-r--r-- 1 tizenglobalapp root   153382 Jul 26 16:00 libgstsubtitleparse_tvplus.so
-rw-r--r-- 1 tizenglobalapp root   940106 Jul 26 16:00 libhls.so
......

Ok, I will try to reproduce it , and then check with HLS team.

Copy link
Member

@JSUYA JSUYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested example with 8.0 device. In HLS tab, When i clicked 90% ~ point of progressbar, video player is still stopped.
I tried waiting for buffering but the video player keeps freezing.

The content in the HLS tab is content that cannot be supported by plusplayer(analyzed by the hls team).
The team said, the content has mis-aligned PTS (~16 sec difference) across video & audio which cause the seek failure (and since seek not returned...no further seek can be processed).
Since the settings or policies of plusplayer may differ from general cases, it is difficult to improve this PR, and the content of the example may be modified or reviewed later.

@JSUYA JSUYA merged commit bec84dd into flutter-tizen:master Aug 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants