Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a regression with accessing the Flutter store file. #7896

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

kenzieschmoll
Copy link
Member

Add back access to the Flutter store file from devtools_shared. This regressed in f4bc98d and was causing errors when making requests to the DevTools server for the flutter GA values. See discussion for more context.

@kenzieschmoll kenzieschmoll requested a review from a team as a code owner June 7, 2024 16:10
@kenzieschmoll kenzieschmoll requested review from bkonyi and DanTup and removed request for a team June 7, 2024 16:10
@kenzieschmoll kenzieschmoll mentioned this pull request Jun 7, 2024
13 tasks
Copy link
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

packages/devtools_shared/lib/src/server/file_system.dart Outdated Show resolved Hide resolved
packages/devtools_shared/lib/src/server/file_system.dart Outdated Show resolved Hide resolved
packages/devtools_shared/lib/src/server/file_system.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@DanTup DanTup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (w/ the nits Ben noted)!

@kenzieschmoll kenzieschmoll merged commit 60fba04 into flutter:master Jun 7, 2024
23 checks passed
@kenzieschmoll kenzieschmoll deleted the gafix branch June 7, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants