-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
License Utility #8460
base: master
Are you sure you want to change the base?
License Utility #8460
Conversation
@kenzieschmoll This is the first part of the work that just covers the license util and associated tests (repo wide check test currently skipped). I will need to quickly follow-up with a couple more PRs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with first pass.
@kenzieschmoll @bkonyi I think I addressed the majority of the feedback. So, probably in a good state for a follow-up review when you get the chance. Please let me know if I missed anything. |
I went through and resolved open comments where possible. There are still a few open comments to address, but looking good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
…n replacement header, and added more tests
@bkonyi @kenzieschmoll Thanks for all the time you've invested so far! I think I managed to address all the issues, but please let me know if I didn't address it correctly or if there's more to change - hopefully not 🙏 Note: I ran into a few environment issues that made it difficult to keep my branch in sync with master. So, there were files I didn't change that were showing up in the PR. I had to cherry-pick and force push to get the branch back to a reasonable state. Hopefully, I didn't lose any of the changes that were requested and that I made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM overall! Just a couple of minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One request for usage instructions, but LGTM overall.
Created a utility for updating licenses in configured source files that can be run via tests and/or standalone.
#8216
Pre-launch Checklist
///
).If you need help, consider asking for help on Discord.