-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Property Editor] Emphasize properties the user has set in their code #8637
base: master
Are you sure you want to change the base?
Conversation
This makes the non-set properties look disabled IMO. Is this something we could put on our list to get UX input on? what about another badge "explicit" or "set" instead of graying out some of the properties? |
We already have 2 potential badges (isDefault and isRequired), and I think we will need to change the UI to fit 3. I've tweaked how we are determining the background color, and added a bunch of different screenshots for various VS Code themes. Let me know what you think - mostly I want this in a nice-ish state for the demo, but I agree this is something we should follow up on with UX. Note: I haven't added comments and tests yet, will add those if we think we should go ahead with these colors for now. |
Another affordance to consider if we want to reduce the number of badges like "default". We could use an asterisk |
@@ -7,7 +7,6 @@ import 'package:flutter/material.dart'; | |||
import 'package:flutter/services.dart'; | |||
|
|||
import '../../../service/editor/api_classes.dart'; | |||
import '../../../shared/primitives/utils.dart'; | |||
import 'property_editor_controller.dart'; | |||
|
|||
class PropertyEditorView extends StatelessWidget { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this widget doesn't provide much value to abstract now. Can we add the _PropertiesList
directly where PropertyEditorView
is currently used? That or make PropertyEditorView
what _PropertiesList
currently is (effectively deleting _PropertiesList
and having PropertyEditorView
contain the body of the current _PropertiesList
)
), | ||
child: Row( | ||
crossAxisAlignment: CrossAxisAlignment.start, | ||
children: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it might be simpler to just add a Container to this row directly:
Row(
children: [
Container(
width: _hasArgIndicatorWidth,
color: argument.hasArgument ? theme.colorScheme.primary : Colors.transparent,
),
...
],
),
Work towards #1948
We would like to highlight the properties that the user has set in their code so that its visually clear what they have set.
Screenshots of various themes: