Serve command still works with --machine flag
#8638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // If --machine flag is true, then the output is a tool-readable JSON. | ||
| // Therefore, skip reading the process output and instead just run the | ||
| // process. | ||
| return processManager.runProcess( |
There was a problem hiding this comment.
if we run the process I think we will wait for this process to exit, which will cause this script to fail for the case where runApp is true. We wait for the serveLocalProcess exit below, so we should be able to use startIndependentProcess here still
There was a problem hiding this comment.
Chatted offline that for now we can check whether --machine and --run-app are both set and if so throw an exception.
kenzieschmoll
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #8621
I noticed that running DevTools locally in VS Code was timing out. This is because the output is JSON when running with
--machine.If
--machineis true, we simply run the serve process instead of starting it and handling the output ourselves.