ci(all): Update Java version for integration tests, update Android APIs #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nohli
approved these changes
Aug 21, 2023
I would like to replace 31 with 34 as soon as Google releases Android 14 officially to be our |
|
Reverted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I missed the fact that Java version is set in 2 places in workflow files and didn't update Java for integration tests in #2055
Additionally I looked at a few other repos that use Android emulators Action that we use and found out that a few of such repos identify 21 and 32 as flaky emulators, which is something we often experience ourselves. As a result I changed min Android API to 22 and max to 31 in attempt to get lower number of failed CI tests due to flakiness of some emulators.
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).