fix(share_plus): #3322 Image preview on iOS downscale to avoid issues #3320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thanks for the contribution. I'd please ask you to follow the PR template: https://github.com/fluttercommunity/plus_plugins/blob/main/.github/PULL_REQUEST_TEMPLATE.md and fix the title. As well, try to provide more context about this fix, ideally creating a bug report showcasing the issue, or showing before and after images, etc. otherwise it is very hard to understand what the purpose of the fix is. |
Victor-Plaud
changed the title
Victor-Plaud
changed the title
Victor-Plaud
changed the title
miquelbeltran
changed the title
Victor-Plaud
force-pushed
the
fix10.0.2-iphone13
branch
from
e827759
to
f0d8d96
Compare
miquelbeltran
changed the title
|
Thanks for providing a ticket with a video recording! Can you show a recording of how it looks with the fix? |
114_1729250336.mp4 |
Victor-Plaud
force-pushed
the
fix10.0.2-iphone13
branch
from
9e31a92
to
0c8fd51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On iPhone 13, when sharing an image and the image is very large, the sharing box may occasionally fail to be awakened.
Related Issues
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).