Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Structure for updating to the NewPassManager #167

Draft
wants to merge 57 commits into
base: main
Choose a base branch
from
Draft

Initial Structure for updating to the NewPassManager #167

wants to merge 57 commits into from

Conversation

tpatki
Copy link
Member

@tpatki tpatki commented Sep 19, 2024 •
edited
Loading

WIP.
Fixes #162.
Fixes #176.

  • Add a CMake check to check for Clang 14 and above
  • Rename perfflow_weave.hpp/cpp to perfflow_weave_legacy_pass.hpp/cpp
  • Add an example similar to the InjectFuncPass in the perfflow_weave_new_pass.hpp/cpp
  • Test the simple example
  • Migrate the functionality from the legacy pass to the new pass .If applicable, also migrate common functionality across both passes (parsing, insertBefore/insertAfter) to its own header that can be shared if no other changes are needed.
  • Test on Lassen with clang10 and clang14.05 (legacy and new pass)
  • Split perfflow_weave_common.hpp into .hpp/.cpp
  • Cleanup the modifyAnnotatedFunctions() method, make it easier to read/explain
  • Clean up commented code
  • Test with various clang versions on different systems
  • Format code

Testing:

  • Ruby : clang versions 14
  • Corona: clang versions 14
  • Turing: clang versions 14
  • Turing: clang versions 15
  • Turing: clang versions 17
  • Lassen: clang versions 10
  • Lassen: clang versions 14, -gcc module
  • Lassen: clang versions 16, -gcc module
  • Lassen: clang versions 15, non-gcc module (several C++ errors that I have been unable to resolve. Note: we don't have a clang-<>gcc-<> style module for clang15 on lassen. These have nothing to do with our code, but some incompatibility with libstdc++)
  • Lassen: clang versions 17, non-gcc module (Similar errors to clang15, note that here too we don't have the clang-<>gcc-<> style module for clang17 on lassen.)

Note: Adiak related testing that builds on top of this PR has been moved to a separate branch, see #172.

@tpatki tpatki marked this pull request as draft September 19, 2024 06:56
@tpatki tpatki mentioned this pull request Sep 25, 2024
Closed
3 tasks
@tpatki tpatki added this to the Release 0.2.0 milestone Sep 25, 2024
@tpatki tpatki mentioned this pull request Sep 28, 2024
Open
5 tasks
slabasan
slabasan reviewed Oct 10, 2024
View reviewed changes
src/c/CMakeLists.txt Outdated
@@ -7,11 +7,15 @@ if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
# require at least Clang 9.0
if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 9.0)
message(FATAL_ERROR "Clang++ version must be at least 9.0!")
elseif (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 11)
elseif (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 15)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we double check these version comparisons? Is PERFFLOWASPECT_CLANG_15_NEWER supposed to be >=clang15 or >clang15?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>= from what I recall from my testing (returns true of clang 15). I will test again.

@tpatki @slabasan
Initial Structure for updating to the NewPassManager
ea4e183
@tpatki @slabasan
Add a basic module pass structure for perfflow_weave_new_pass. Untested.
723ba84
@tpatki @slabasan
Formatted.
622d82b
@tpatki @slabasan
Add headers, comment one registration technique
b880e84
@tpatki @slabasan
Formatted.
e3e3469
@tpatki @slabasan
Add missing brace
51ab4e9
@tpatki @slabasan
Builds, but pass is not picked up with -XClang -load
8b5a89f
@tpatki @slabasan
Try the EP Early Simplification Callback, similar to our legacy pass
d2578ec
@tpatki @slabasan
Comment out the example code
8506007
@tpatki @slabasan
Add missing ;
633c121
@tpatki @slabasan
Try adding the -fpass-plugin for clang 14+
656cd9d
@tpatki @slabasan
Clean up, edit CMake to add -fpass-plugin for Clang14+, edit host-config
ff32d8c
@tpatki @slabasan
Update the CUDA compiler -Xcompiler flag.
4c3d2bf
@tpatki @slabasan
Formatted
acf39c7
@tpatki @slabasan
Check if we can intercept main, so we know where to insert the Adiak …
b94231a 
…call
@tpatki @slabasan
Builds correctly, can intercept main.
40885fa
@tpatki @slabasan
First attempt at restructuring. Will probably not build. May split in…
ad88736 
…to common.hpp/cpp as opposed to just the current hpp file.
@tpatki @slabasan
Add relevant headers, only testing New pass
d880a22
@tpatki @slabasan
Pick the right flag
4d57518
@tpatki @slabasan
NewPassMgr builds correctly. Buildlegacy pass now
a24825d
@tpatki @slabasan
Woohoo! We have a working NewPassManager that generates PFW files. Fo…
f2b3ffe 
…rmatting pass
tpatki and others added 28 commits October 10, 2024 12:39
@tpatki @slabasan
Debugging.
4554d05
@tpatki @slabasan
Fix several issues due to uncommitted changes previously. Can identif…
5274717 
…y the problem, but still debugging
@slabasan
add more lassen host configs for newer clang versions
a473a7a
@slabasan
print operand names
18f0e60
@tpatki @slabasan
Edit print
b422715
@tpatki @slabasan
Fix my stupid bug
6c5a230
@tpatki @slabasan
Fix my stupid bug
57e7a82
@tpatki @slabasan
Format prints
56897e1
@tpatki @slabasan
CString didn't work. try later
cba5b58
@tpatki @slabasan
print formatting
c07d36a
@tpatki @slabasan
Test one level up with Clang 16. We can switch based on Clang version…
e07fdb6 
… if that works.
@tpatki @slabasan
Hostfile for Lassen that works with CUDA.
d36ffa7
@tpatki @slabasan
Split between >clang15 and <clang15. Plan on using flegacy-pass-mge f…
57375eb 
…or clang14
@tpatki @slabasan
Formatting pass
6a3afd7
@tpatki @slabasan
Caught a bug
cef5f63
@tpatki @slabasan
Several build fixes
da31b6a
@tpatki @slabasan
The clang 15 and 17 files DO NOT WORK on Lassen. Need to find the rig…
17f4483 
…ht flags
@tpatki @slabasan
Add corona hostfile that works correctly
3b968b5
@slabasan
update/add lassen host configs for clang 16.0.6, cuda, gcc modules
6a215ce
@slabasan
add new lassen clang16 gcc8 host file, fix LLVM path
6f8296f
@slabasan
update LLVM dir in same top location for clang compiler
ceb0ee8
@slabasan
add lassen host configs for clang/ibm modules
1ee82b2
@slabasan
add lassen clang ibm gcc host configs
8878639
@slabasan
add lassen clang16 host config
63c2a88
@slabasan
add missing cmake file extension
b71a3a1
@slabasan
add missing if checks
cf9d383 
does not include PassManagerBuilder.h header that was removed in clang17
@slabasan
add clang17 tioga host config
ab302aa
@slabasan
fix for clang18 builds
5e50d3a 
getInt8PtrTy removed in clang18
@tpatki tpatki mentioned this pull request Oct 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slabasan slabasan slabasan left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Release 0.2.0
2 participants
@tpatki @slabasan