Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Structure for updating to the NewPassManager #167

Draft
wants to merge 57 commits into
base: main
Choose a base branch
from
Draft

Initial Structure for updating to the NewPassManager #167

wants to merge 57 commits into from

Commits on Oct 10, 2024

  1. Initial Structure for updating to the NewPassManager

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ea4e183 View commit details
    Browse the repository at this point in the history

  2. Add a basic module pass structure for perfflow_weave_new_pass. Untested.

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    723ba84 View commit details
    Browse the repository at this point in the history

  3. Formatted.

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    622d82b View commit details
    Browse the repository at this point in the history

  4. Add headers, comment one registration technique

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b880e84 View commit details
    Browse the repository at this point in the history

  5. Formatted.

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e3e3469 View commit details
    Browse the repository at this point in the history

  6. Add missing brace

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    51ab4e9 View commit details
    Browse the repository at this point in the history

  7. Builds, but pass is not picked up with -XClang -load

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    8b5a89f View commit details
    Browse the repository at this point in the history

  8. Try the EP Early Simplification Callback, similar to our legacy pass

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d2578ec View commit details
    Browse the repository at this point in the history

  9. Comment out the example code

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    8506007 View commit details
    Browse the repository at this point in the history

  10. Add missing ;

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    633c121 View commit details
    Browse the repository at this point in the history

  11. Try adding the -fpass-plugin for clang 14+

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    656cd9d View commit details
    Browse the repository at this point in the history

  12. Clean up, edit CMake to add -fpass-plugin for Clang14+, edit host-config

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ff32d8c View commit details
    Browse the repository at this point in the history

  13. Update the CUDA compiler -Xcompiler flag.

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    4c3d2bf View commit details
    Browse the repository at this point in the history

  14. Formatted

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    acf39c7 View commit details
    Browse the repository at this point in the history

  15. Check if we can intercept main, so we know where to insert the Adiak … 

    …call
    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b94231a View commit details
    Browse the repository at this point in the history

  16. Builds correctly, can intercept main.

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    40885fa View commit details
    Browse the repository at this point in the history

  17. First attempt at restructuring. Will probably not build. May split in… 

    …to common.hpp/cpp as opposed to just the current hpp file.
    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ad88736 View commit details
    Browse the repository at this point in the history

  18. Add relevant headers, only testing New pass

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d880a22 View commit details
    Browse the repository at this point in the history

  19. Pick the right flag

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    4d57518 View commit details
    Browse the repository at this point in the history

  20. NewPassMgr builds correctly. Buildlegacy pass now

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a24825d View commit details
    Browse the repository at this point in the history

  21. Woohoo! We have a working NewPassManager that generates PFW files. Fo… 

    …rmatting pass
    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f2b3ffe View commit details
    Browse the repository at this point in the history

  22. Comment out some parts of legacy code

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5fb02b7 View commit details
    Browse the repository at this point in the history

  23. Code Cleanup Pass 1. Rename some classes, variables, remove commented… 

    … code.
    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5434752 View commit details
    Browse the repository at this point in the history

  24. Split perfflow_weave_common into hpp and cpp

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    259b9d8 View commit details
    Browse the repository at this point in the history

  25. Formatting pass

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    15c3f2f View commit details
    Browse the repository at this point in the history

  26. Remove Adiak testing and main function hooks from this PR

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    2c6e2ff View commit details
    Browse the repository at this point in the history

  27. Formatting pass

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    3596fed View commit details
    Browse the repository at this point in the history

  28. Edit the Weaver CMake to allow c++17 build.

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b2ee0f2 View commit details
    Browse the repository at this point in the history

  29. Debugging commit, revert later.

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    77f86bc View commit details
    Browse the repository at this point in the history

  30. Debugging.

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    4554d05 View commit details
    Browse the repository at this point in the history

  31. Fix several issues due to uncommitted changes previously. Can identif… 

    …y the problem, but still debugging
    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5274717 View commit details
    Browse the repository at this point in the history

  32. add more lassen host configs for newer clang versions

    @slabasan
    slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a473a7a View commit details
    Browse the repository at this point in the history

  33. print operand names

    @slabasan
    slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    18f0e60 View commit details
    Browse the repository at this point in the history

  34. Edit print

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b422715 View commit details
    Browse the repository at this point in the history

  35. Fix my stupid bug

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6c5a230 View commit details
    Browse the repository at this point in the history

  36. Fix my stupid bug

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    57e7a82 View commit details
    Browse the repository at this point in the history

  37. Format prints

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    56897e1 View commit details
    Browse the repository at this point in the history

  38. CString didn't work. try later

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    cba5b58 View commit details
    Browse the repository at this point in the history

  39. print formatting

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    c07d36a View commit details
    Browse the repository at this point in the history

  40. Test one level up with Clang 16. We can switch based on Clang version… 

    … if that works.
    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e07fdb6 View commit details
    Browse the repository at this point in the history

  41. Hostfile for Lassen that works with CUDA.

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d36ffa7 View commit details
    Browse the repository at this point in the history

  42. Split between >clang15 and <clang15. Plan on using flegacy-pass-mge f… 

    …or clang14
    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    57375eb View commit details
    Browse the repository at this point in the history

  43. Formatting pass

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6a3afd7 View commit details
    Browse the repository at this point in the history

  44. Caught a bug

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    cef5f63 View commit details
    Browse the repository at this point in the history

  45. Several build fixes

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    da31b6a View commit details
    Browse the repository at this point in the history

  46. The clang 15 and 17 files DO NOT WORK on Lassen. Need to find the rig… 

    …ht flags
    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    17f4483 View commit details
    Browse the repository at this point in the history

  47. Add corona hostfile that works correctly

    @tpatki @slabasan
    tpatki authored and slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    3b968b5 View commit details
    Browse the repository at this point in the history

  48. update/add lassen host configs for clang 16.0.6, cuda, gcc modules

    @slabasan
    slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6a215ce View commit details
    Browse the repository at this point in the history

  49. add new lassen clang16 gcc8 host file, fix LLVM path

    @slabasan
    slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6f8296f View commit details
    Browse the repository at this point in the history

  50. update LLVM dir in same top location for clang compiler

    @slabasan
    slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ceb0ee8 View commit details
    Browse the repository at this point in the history

  51. add lassen host configs for clang/ibm modules

    @slabasan
    slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    1ee82b2 View commit details
    Browse the repository at this point in the history

  52. add lassen clang ibm gcc host configs

    @slabasan
    slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    8878639 View commit details
    Browse the repository at this point in the history

  53. add lassen clang16 host config

    @slabasan
    slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    63c2a88 View commit details
    Browse the repository at this point in the history

  54. add missing cmake file extension

    @slabasan
    slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b71a3a1 View commit details
    Browse the repository at this point in the history

  55. add missing if checks 

    does not include PassManagerBuilder.h header that was removed in clang17
    @slabasan
    slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    cf9d383 View commit details
    Browse the repository at this point in the history

  56. add clang17 tioga host config

    @slabasan
    slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ab302aa View commit details
    Browse the repository at this point in the history

  57. fix for clang18 builds 

    getInt8PtrTy removed in clang18
    @slabasan
    slabasan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5e50d3a View commit details
    Browse the repository at this point in the history