Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix user ownership of files in jovyan home #21

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented Aug 31, 2023

This also adds the start of the custom launcher, however the extension seems buggy as the notebook cwd is not honored, so it does not work. The custom icon also did not work. I removed those sections for now and we can hopefully debug further next year!

Ping @milroy !

This also adds the start of the custom launcher, however
the extension seems buggy as the notebook cwd is not honored,
so it does not work. The custom icon also did not work.
I removed those sections for now and we can hopefully
debug further next year!

Signed-off-by: vsoch <[email protected]>
Copy link
Member

@milroy milroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thanks!

@vsoch
Copy link
Member Author

vsoch commented Aug 31, 2023

okay I'll merge and trigger a build.

@vsoch vsoch merged commit 9717db2 into master Aug 31, 2023
3 checks passed
@vsoch vsoch deleted the fix-init-user-add-links-to-dashboard branch August 31, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants