Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCIC configuration updates #46

Merged
merged 2 commits into from
Aug 29, 2024
Merged

HPCIC configuration updates #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f48be3
README: update SSL instructions
milroy Aug 29, 2024
e20af97
aws ssl config: increase hub resources for larger tutorials
milroy Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions 2024-HPCIC-AWS/JupyterNotebook/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,6 +845,8 @@ helm install flux-jupyter jupyterhub/jupyterhub --values aws/config-aws.yaml
helm install flux-jupyter jupyterhub/jupyterhub --values aws/config-aws-ssl.yaml
```

If you're configuring SSL, you will need to get the service DNS name after creation. With that name you can assign a CNAME as appropriate. Then delete the `autohttps` pod, which triggers a pod recreation and certificate generation.

If you mess something up, you can change the file and run `helm upgrade`:

```bash
Expand Down
24 changes: 15 additions & 9 deletions 2024-HPCIC-AWS/JupyterNotebook/aws/config-aws-ssl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ hub:
tag: "hpcic-2024"
pullPolicy: Always

# Increase the resources for large tutorials
resources:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't lead to setting limits/requests and the pod in Guaranteed and OOM errors and the notebooks being killed?

Copy link
Member Author

@milroy milroy Aug 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it. In general if you have a Guaranteed pod with resource consumption very close to the physical limits of the machine it is likely to get OOM killed regardless of whether it's Guaranteed.

requests:
cpu: 28
memory: 96Gi

# # https://z2jh.jupyter.org/en/latest/administrator/optimization.html#scaling-up-in-time-user-placeholders
# scheduling:
# podPriority:
Expand Down Expand Up @@ -61,19 +67,19 @@ singleuser:
- name: init-myservice
image: ghcr.io/flux-framework/flux-jupyter-init:hpcic-2024
command: ["/entrypoint.sh"]
volumeMounts:
- name: flux-tutorial
mountPath: /home/jovyan
# volumeMounts:
# - name: flux-tutorial
# mountPath: /home/jovyan

# This is how we get the tutorial files added
storage:
type: none

# gitRepo volume is deprecated so we need another way
# https://kubernetes.io/docs/concepts/storage/volumes/#gitrepo
extraVolumes:
- name: flux-tutorial
emptyDir: {}
extraVolumeMounts:
- name: flux-tutorial
mountPath: /home/jovyan
# extraVolumes:
# - name: flux-tutorial
# emptyDir: {}
# extraVolumeMounts:
# - name: flux-tutorial
# mountPath: /home/jovyan
Loading