Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Prebuild Stage Feature #430

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oliverbaehler
Copy link
Contributor

I tried implementing a solution for issue #414
Since this is my first contribution in go i am not quiet sure how good it is. But i tested it and it works. But hard to tell.

I created this PR as Draft, so we can discuss over the feature.
If the feature is seen as plausible, I will commit further changes (tests, etc) which comply with the contributions guidelines.

I didn't make them yet, because I don't want to waste time for something that could be rejected.

Signed-off-by: Oliver Bähler [email protected]

…r discussion

If the feature is seen as plausible, I will commit further changes (tests, etc) which comply with the contributions guidelines

Signed-off-by: Oliver Bähler <[email protected]>
@oliverbaehler oliverbaehler changed the title Draft: Prebuild Stage Feature WIP: Prebuild Stage Feature Sep 17, 2021
@vcariven
Copy link

I have tested your PR (#430) with my own stuff and it's working pretty well. I hope it will be merged soon.

@vcariven
Copy link

@stefanprodan What is your opinion about the clarified scope of the preBuild feature (#414 (comment)), that @oliverbaehler implemented in this PR ?
Do you think we can expect it to be merged once the reviews are passed or does it break the spirit of the kustomize-controller ?
Regards,

@oliverbaehler
Copy link
Contributor Author

I guess this won't be implemented

@adusumillipraveen
Copy link

Just going through this, any reason why this wasn't picked? It will simplify a lot of kustomization files with paths made dynamic.

@tuxillo
Copy link

tuxillo commented Jun 6, 2024

Are there any plans to include this? Thanks!

@pauldotknopf
Copy link

+1 I would love this as well. It would greatly simplify my repository layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants