-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sops: drop forked keyservices #947
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
added
enhancement
New feature or request
area/sops
SOPS related issues and pull requests
labels
Aug 15, 2023
hiddeco
force-pushed
the
drop-forked-keyservices
branch
2 times, most recently
from
August 15, 2023 18:11
b9f9371
to
7198bc9
Compare
hiddeco
force-pushed
the
drop-forked-keyservices
branch
from
August 25, 2023 12:58
7198bc9
to
6bfc0a1
Compare
This updates `go.mozilla.org/sops/v3` to the `v3.8.0-rc.1` release of `github.com/getsops/sops/v3`. This (finally) allows us to drop our forked key sources, as they have now been contributed upstream in a slightly modified form which still allows us to maintain control over the used credentials in isolation. Signed-off-by: Hidde Beydals <[email protected]>
As the forked code has been contributed upstream in a modified format. Signed-off-by: Hidde Beydals <[email protected]>
As the forked code has been contributed upstream in a modified format. Signed-off-by: Hidde Beydals <[email protected]>
As the forked code has been contributed upstream in a modified format. We continue to inject our own default credentials in the key server if none are provided by the Kustomization, to ensure we do not shell out to `az`. Signed-off-by: Hidde Beydals <[email protected]>
As the forked code has been contributed upstream in a modified format. Signed-off-by: Hidde Beydals <[email protected]>
As the forked code has been contributed upstream in a modified format. Signed-off-by: Hidde Beydals <[email protected]>
As the forked code has been contributed upstream in a modified format. Signed-off-by: Hidde Beydals <[email protected]>
As all remaining code is now no longer derived from MPL-2.0 licensed code. Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
drop-forked-keyservices
branch
from
August 25, 2023 13:04
6bfc0a1
to
d02c5ff
Compare
stefanprodan
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @hiddeco 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/getsops/sops/releases/tag/v3.8.0-rc.1