Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] auth setup page issues #5552

Open
2 tasks done
Tracked by #5783
davidmirror-ops opened this issue Jul 10, 2024 · 5 comments · May be fixed by #5863
Open
2 tasks done
Tracked by #5783

[Docs] auth setup page issues #5552

davidmirror-ops opened this issue Jul 10, 2024 · 5 comments · May be fixed by #5863
Assignees
Labels
documentation Improvements or additions to documentation documentation-backlogged For internal use. Reserved for community team workflow. good first issue Good for newcomers hacktoberfest

Comments

@davidmirror-ops
Copy link
Contributor

Description

We need to fix the following problems for the auth setup docs to be more precise:

  1. The steps for MS Entra ID have to be updated to reflect the current location of settings on the Azure UI
  2. The indentation for configmap.adminServer.security is wrong. It should be one level deeper (under server):
configmap:
  adminServer:
    server:
      httpPort: 8088
      grpc:
        port: 8089
      security:
        secure: false
        useAuth: true
        allowCors: true
        allowedOrigins:
 # Accepting all domains for Sandbox installation
          - "*"
        allowedHeaders:
          - "Content-Type"
  1. Step 8 and beyond are folded inside the Note block when it should be out
  2. There have been users indicating that in general, this page is hard to understand. Try to improve verbiage to make it easier to follow.

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@davidmirror-ops davidmirror-ops added documentation Improvements or additions to documentation untriaged This issues has not yet been looked at by the Maintainers labels Jul 10, 2024
Copy link

runllm bot commented Jul 10, 2024

Issue Title: [Docs] auth setup page issues

Issue Body:

Description

We need to fix the following problems for the auth setup docs to be more precise:

  1. The steps for MS Entra ID have to be updated to reflect the current location of settings on the Azure UI.
  2. The indentation for configmap.adminServer.security is wrong. It should be one level deeper (under server):
configmap:
  adminServer:
    server:
      httpPort: 8088
      grpc:
        port: 8089
      security:
        secure: false
        useAuth: true
        allowCors: true
        allowedOrigins:
          # Accepting all domains for Sandbox installation
          - "*"
        allowedHeaders:
          - "Content-Type"
  1. Step 8 and beyond are folded inside the Note block when it should be out.
  2. There have been users indicating that in general, this page is hard to understand. Try to improve verbiage to make it easier to follow.

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes

Sources:


This is an AI-generated response and your feedback is appreciated! Please leave a 👍 if this is helpful and 👎 if it is not.

Mention @RunLLM to ask follow-up questions. See runllm.com for more!

@davidmirror-ops davidmirror-ops self-assigned this Jul 25, 2024
@eapolinario eapolinario added backlogged For internal use. Reserved for contributor team workflow. documentation-backlogged For internal use. Reserved for community team workflow. and removed untriaged This issues has not yet been looked at by the Maintainers backlogged For internal use. Reserved for contributor team workflow. labels Jul 25, 2024
@davidmirror-ops
Copy link
Contributor Author

davidmirror-ops commented Sep 10, 2024

Additional findings:

a. Step 3 for flyte-core in the Apply OIDC Configuration section should be changed from manually editing the flyteadmin secret to just adding the following to the values:

flyte-core

flyteadmin:
  secrets:
    oidc_client_secret: <client_secret_from_your_IDP>

@Murdock9803
Copy link
Contributor

@davidmirror-ops I would love to contribute to this issue, Can you please assign this to me ? 🙌

@davidmirror-ops
Copy link
Contributor Author

@Murdock9803 looking forward to your contributions!

@pranshustuff
Copy link

Hi I have fixed the issues, please review and give me feedback. I hope it isn't an problem that I wasn't assigned this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation documentation-backlogged For internal use. Reserved for community team workflow. good first issue Good for newcomers hacktoberfest
Projects
Status: Assigned
Development

Successfully merging a pull request may close this issue.

4 participants