Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update auth_setup.rst #5863

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pranshustuff
Copy link

@pranshustuff pranshustuff commented Oct 18, 2024

Tracking issue

Closes #5552

Why are the changes needed?

The docs had a few issues as mentioned in the issue and the intro was slightly hard to read and understand.

What changes were proposed in this pull request?

  1. The steps for MS Entra ID tab in Identity Management layer : OIDC were updated and formatted in detail, to keep up with Azure UI changes.
  2. The indentation for configmap.adminServer.security was corrected.
  3. Steps 8 onward were taken out of the Notes block.
  4. The introduction to Identity server and authorization server was formatted for better readability.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Docs link

Authenticating in Flyte page, changes mentioned above

Fixed the following issues:
1. The steps for MS Entra ID have to be updated to reflect the current location of settings on the Azure UI
2. fixed indentation error in ``configmap.adminServer.security``
3. Step 8 and beyond are folded inside the Note block when it should be out.
4. made the intro slightly easier to read.


Signed-off-by: Pranshu <[email protected]>
@pranshustuff pranshustuff changed the title Update auth_setup.rst [Docs] Update auth_setup.rst Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] auth setup page issues
1 participant