Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-619 Add pydata version switcher #5846

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Oct 14, 2024

Why are the changes needed?

Allow readers to choose the docs version that corresponds to the version of Flyte they are using.

What changes were proposed in this pull request?

Adds switcher.json and configuration changes in conf.py

How was this patch tested?

Tested locally.

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Docs link

https://flyte--5846.org.readthedocs.build/en/5846/

Signed-off-by: nikki everett <[email protected]>
@neverett neverett self-assigned this Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.35%. Comparing base (a8b16a5) to head (8a1f9fe).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5846      +/-   ##
==========================================
+ Coverage   34.48%   36.35%   +1.86%     
==========================================
  Files        1138     1304     +166     
  Lines      102742   110148    +7406     
==========================================
+ Hits        35434    40040    +4606     
- Misses      63634    65941    +2307     
- Partials     3674     4167     +493     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.57% <ø> (-0.04%) ⬇️
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.26% <ø> (?)
unittests-flyteidl 7.17% <ø> (ø)
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 42.02% <ø> (ø)
unittests-flytestdlib 55.37% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant