upstream no output lp retrieval

[hamersaw]

Tracking issue

NA

Why are the changes needed?

This PR ensures that if the LP has no output data that a FlyteAdmin request for the data is not sent - mitigating a whole heap of issues that can occur in that path.

What changes were proposed in this pull request?

Add LP interfaces to the FlyteWorkflow CR and use them to inform whether an LP execution has outputs and data retrieval is necessary.

How was this patch tested?

Tested locally under a variety of use-cases.

Setup process

Screenshots

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

NA

Docs link

NA

[codecov]

Codecov Report

Attention: Patch coverage is 22.55639% with 309 lines in your changes missing coverage. Please review.

Project coverage is 36.28%. Comparing base (003b8de) to head (262aed8).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...yteworkflow/v1alpha1/mocks/ExecutableLaunchPlan.go	0.00%	51 Missing ⚠️
...flyteworkflow/v1alpha1/mocks/ExecutableWorkflow.go	0.00%	51 Missing ⚠️
...teworkflow/v1alpha1/mocks/ExecutableSubWorkflow.go	0.00%	34 Missing ⚠️
...peller/pkg/apis/flyteworkflow/v1alpha1/workflow.go	0.00%	24 Missing ⚠️
.../apis/flyteworkflow/v1alpha1/mocks/MetaExtended.go	0.00%	17 Missing ⚠️
.../flyteworkflow/v1alpha1/mocks/SubWorkflowGetter.go	0.00%	17 Missing ⚠️
...er/pkg/compiler/common/mocks/interface_provider.go	0.00%	17 Missing ⚠️
flytepropeller/pkg/compiler/utils.go	15.00%	16 Missing and 1 partial ⚠️
.../controller/executors/mocks/sub_workflow_getter.go	0.00%	17 Missing ⚠️
.../nodes/subworkflow/launchplan/mocks/flyte_admin.go	0.00%	16 Missing ⚠️
... and 8 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5847      +/-   ##
==========================================
- Coverage   36.35%   36.28%   -0.07%     
==========================================
  Files        1304     1305       +1     
  Lines      110148   110471     +323     
==========================================
+ Hits        40043    40088      +45     
- Misses      65938    66209     +271     
- Partials     4167     4174       +7     

Flag	Coverage Δ
unittests-datacatalog	51.37% <ø> (ø)
unittests-flyteadmin	55.59% <50.00%> (-0.01%)	⬇️
unittests-flytecopilot	12.17% <ø> (ø)
unittests-flytectl	62.21% <ø> (ø)
unittests-flyteidl	7.17% <ø> (ø)
unittests-flyteplugins	53.35% <ø> (ø)
unittests-flytepropeller	41.66% <21.70%> (-0.36%)	⬇️
unittests-flytestdlib	55.35% <ø> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.