DOC-666 Change "Accessing attributes" to "Accessing attributes in workflows" #5886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kflows" Signed-off-by: Peeter Piegaze <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5886 +/- ##
==========================================
- Coverage 36.71% 32.83% -3.89%
==========================================
Files 1304 1008 -296
Lines 130081 106690 -23391
==========================================
- Hits 47764 35035 -12729
+ Misses 78147 68544 -9603
+ Partials 4170 3111 -1059
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
neverett
approved these changes
Oct 22, 2024
|
|
||
| ```{eval-rst} | ||
| .. tags:: Basic | ||
| ``` | ||
|
|
||
| You can directly access attributes on output promises for lists, dicts, dataclasses and combinations of these types in Flyte. This functionality facilitates the direct passing of output attributes within workflows, | ||
| enhancing the convenience of working with complex data structures. | ||
| You can directly access attributes on output promises for lists, dicts, dataclasses and combinations of these types in Flyte. |
There was a problem hiding this comment.
Suggested change
| You can directly access attributes on output promises for lists, dicts, dataclasses and combinations of these types in Flyte. | |
| You can directly access attributes on output promises for lists, dictionaries, dataclasses, and combinations of these types in Flyte. |
|
/assign |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
DOC-666
Why are the changes needed?
Minor clarification suggested by @thomas here: https://unionai.slack.com/archives/C02CMUNT4PQ/p1729211883670849
What changes were proposed in this pull request?
Change in wording. Additional explanation