-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-666 Change "Accessing attributes" to "Accessing attributes in workflows" #5886
base: master
Are you sure you want to change the base?
DOC-666 Change "Accessing attributes" to "Accessing attributes in workflows" #5886
Conversation
…kflows" Signed-off-by: Peeter Piegaze <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5886 +/- ##
==========================================
- Coverage 36.71% 32.83% -3.89%
==========================================
Files 1304 1008 -296
Lines 130081 106690 -23391
==========================================
- Hits 47764 35035 -12729
+ Misses 78147 68544 -9603
+ Partials 4170 3111 -1059
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some small copyedits, otherwise LGTM
|
||
```{eval-rst} | ||
.. tags:: Basic | ||
``` | ||
|
||
You can directly access attributes on output promises for lists, dicts, dataclasses and combinations of these types in Flyte. This functionality facilitates the direct passing of output attributes within workflows, | ||
enhancing the convenience of working with complex data structures. | ||
You can directly access attributes on output promises for lists, dicts, dataclasses and combinations of these types in Flyte. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can directly access attributes on output promises for lists, dicts, dataclasses and combinations of these types in Flyte. | |
You can directly access attributes on output promises for lists, dictionaries, dataclasses, and combinations of these types in Flyte. |
/assign |
Tracking issue
DOC-666
Why are the changes needed?
Minor clarification suggested by @thomas here: https://unionai.slack.com/archives/C02CMUNT4PQ/p1729211883670849
What changes were proposed in this pull request?
Change in wording. Additional explanation