Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flytepropeller] Add tests in v1alpha #5896

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

DenChenn
Copy link
Member

@DenChenn DenChenn commented Oct 23, 2024

Tracking issue

Example: Related to #4209

Why are the changes needed?

Improve code tests coverage.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

Screenshot 2024-10-23 at 6 49 22 PM

Related PRs

#4234

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.85%. Comparing base (1652d4c) to head (49ccd36).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5896      +/-   ##
==========================================
+ Coverage   34.96%   36.85%   +1.89%     
==========================================
  Files        1143     1309     +166     
  Lines      122098   130895    +8797     
==========================================
+ Hits        42688    48241    +5553     
- Misses      75721    78472    +2751     
- Partials     3689     4182     +493     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.03% <ø> (+0.02%) ⬆️
unittests-flytecopilot 11.73% <ø> (ø)
unittests-flytectl 62.45% <ø> (?)
unittests-flyteidl 6.92% <ø> (ø)
unittests-flyteplugins 53.59% <ø> (ø)
unittests-flytepropeller 43.18% <ø> (+0.17%) ⬆️
unittests-flytestdlib 55.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DenChenn DenChenn force-pushed the flytepropeller-pkg-apis-flyteworkflow-test branch from 306bc12 to d7e21cb Compare October 23, 2024 11:02
@DenChenn DenChenn marked this pull request as ready for review October 23, 2024 11:09
Signed-off-by: DenChenn <[email protected]>
@DenChenn DenChenn force-pushed the flytepropeller-pkg-apis-flyteworkflow-test branch from d7e21cb to 49ccd36 Compare October 23, 2024 11:24
@DenChenn DenChenn changed the title [flytepropeller] Add Tests in v1alpha [flytepropeller] Add tests in v1alpha Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

1 participant