Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Flyteadmin Webhook #434

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Flyteadmin Webhook #434

wants to merge 9 commits into from

Conversation

pingsutw
Copy link
Member

Read then delete this section

- Make sure to use a concise title for the pull-request.

- Use #patch, #minor or #major in the pull-request title to bump the corresponding version. Otherwise, the patch version
will be bumped. More details

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@pingsutw pingsutw marked this pull request as draft August 21, 2023 18:46
Signed-off-by: Kevin Su <[email protected]>
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #434 (7ac5755) into master (5198c9b) will increase coverage by 2.55%.
The diff coverage is n/a.

❗ Current head 7ac5755 differs from pull request most recent head 485ae22. Consider uploading reports for the commit 485ae22 to get more accurate results

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
+ Coverage   75.92%   78.48%   +2.55%     
==========================================
  Files          18       18              
  Lines        1458     1250     -208     
==========================================
- Hits         1107      981     -126     
+ Misses        294      212      -82     
  Partials       57       57              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant