Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict Dynamic Workflow for Interactive Mode #2849

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

Mecoli1219
Copy link
Contributor

@Mecoli1219 Mecoli1219 commented Oct 22, 2024

Tracking Issues

flyteorg/flyte#5907

Why are the changes needed?

Dynamic workflow is not supported in interactive mode now, so we should throw an error when executing workflow that contains dynamic workflow.

What changes were proposed in this pull request?

  • Throw an error if an entity is a dynamic workflow during interactive mode
  • Add multiple unit tests to test the logic of extracting the target object for pickling

How was this patch tested?

Setup process

Create a dynamic workflow and execute it in interactive mode.

Screenshots

image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 38.32%. Comparing base (e325206) to head (d7c94a8).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
flytekit/remote/remote.py 12.50% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2849      +/-   ##
==========================================
- Coverage   45.44%   38.32%   -7.13%     
==========================================
  Files         196      196              
  Lines       20365    20407      +42     
  Branches     2631     2634       +3     
==========================================
- Hits         9255     7821    -1434     
- Misses      10660    12377    +1717     
+ Partials      450      209     -241     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit f1adbe8 into flyteorg:master Oct 22, 2024
104 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants