Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No-op commit to trigger new version #2854

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

eapolinario
Copy link
Collaborator

@eapolinario eapolinario commented Oct 23, 2024

We use setuptools_scm to define the version file used to produce the flytekit wheels. Unfortunately it doesn't handle the case of multiple tags pointing to the same commit, it always picks up the earliest.

So, in order to publish 1.13.11, let's just push a no-op change to the release-v1.13 branch.

Tested it locally by doing:

~/repos/flytekit #v1.13.10
❯ python -m setuptools_scm

1.13.10

~/repos/flytekit #v1.13.10
❯ git tag v1.13.11

~/repos/flytekit #v1.13.11
❯ python -m setuptools_scm

1.13.10

# Push a commit and tag 1.13.11
...
~/repos/flytekit @0233cfea
❯ python -m setuptools_scm

1.13.11.dev1+g0233cfea6

~/repos/flytekit @0233cfea
❯ git tag v1.13.11
fatal: tag 'v1.13.11' already exists

~/repos/flytekit @0233cfea
❯ git tag -d v1.13.11
Deleted tag 'v1.13.11' (was 83474c67d)

~/repos/flytekit @0233cfea
❯ git tag v1.13.11

~/repos/flytekit #v1.13.11
❯ python -m setuptools_scm

1.13.11

Notice how even creating a tag setuptools_scm still thinks that we're at 1.13.10.

Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario eapolinario merged commit 662bc66 into release-v1.13 Oct 23, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants