Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated jupyter interaction #2858

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Updated jupyter interaction #2858

merged 3 commits into from
Oct 25, 2024

Conversation

kumare3
Copy link
Contributor

@kumare3 kumare3 commented Oct 24, 2024

Simplified interaction with executions from Jupyter.

  1. Automatic detection of Interactive Mode / Jupyter Environment, with ability to Force disable
  2. for exe = remote.execute(...)
  3. Explicitly get execution url exe.execution_url
  4. Jupyter automatically pretty prints execution to point to URL and if failed shows error
  5. Wait for execution to complete exe = exe.wait(poll_interval=1)
  6. OR sync manually exe.sync

.sync
.execution_url
.wait
added

Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 32.50000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 56.21%. Comparing base (3fc51af) to head (9e5c30b).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
flytekit/remote/executions.py 27.27% 24 Missing ⚠️
flytekit/remote/remote.py 60.00% 0 Missing and 2 partials ⚠️
flytekit/models/core/execution.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2858       +/-   ##
===========================================
+ Coverage   45.53%   56.21%   +10.67%     
===========================================
  Files         196      196               
  Lines       20418    20506       +88     
  Branches     2647     2659       +12     
===========================================
+ Hits         9298    11527     +2229     
+ Misses      10658     8276     -2382     
- Partials      462      703      +241     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

flytekit/remote/executions.py Outdated Show resolved Hide resolved
@davidmirror-ops
Copy link

cc @Mecoli1219

Signed-off-by: Ketan Umare <[email protected]>
@kumare3 kumare3 merged commit 2d979ff into master Oct 25, 2024
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants