-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type Mismatching while Serializing Dataclass with Union #2859
Open
mao3267
wants to merge
7
commits into
flyteorg:master
Choose a base branch
from
mao3267:union-serialize-bug
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+56
−3
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
96c0e5c
fix: type matching err for union in dataclass
mao3267 f647bd3
test: add Union[None, FlyteFile] to test optional in dataclass
mao3267 a7ea0e9
fix: add error for multiple flytetypes in union while serializing
mao3267 dff0829
test: serialize multiple dataclass in union
mao3267 b9a4051
test: error while serialize union with multiple flytetypes
mao3267 c4c3ce7
refactor: lint
mao3267 4894ae5
refactor: lint
mao3267 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
from dataclasses import dataclass | ||
from flytekit.types.file import FlyteFile | ||
from flytekit.types.structured.structured_dataset import StructuredDataset | ||
from flytekit.core.type_engine import DataclassTransformer | ||
from typing import Union | ||
import pytest | ||
|
||
def test_dataclass_union_with_multiple_flytetypes_error(): | ||
@dataclass | ||
class DC(): | ||
x: Union[None, FlyteFile, StructuredDataset] | ||
|
||
|
||
dc = DC(x="s3://my-bucket/my-file") | ||
with pytest.raises(ValueError, match="Cannot have two Flyte types in a Union type"): | ||
DataclassTransformer()._make_dataclass_serializable(dc, DC) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually can you write one more unit test for me please? (and add it under
test_dataclass.py
this file is getting too big).then call
_make_dataclass_serializable
onUnion[None, A, B]
whereb = B(x="s3://tmp)
or something.