Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIDATIMP-1443: Improve mapping profile for Holdings for handling multiple Holdings mapping #1404

Closed
wants to merge 9 commits into from

Conversation

mariia-aloshyna
Copy link
Contributor

Merge together with MODDICORE-336

Purpose

The main goal is to update mappin profile for Holdings. "permanentLocationId"-field should be updated to handle it as "repeatable" field via specific action

Approach

  • Change holdings.permanentLocationId field to a repeatable field
  • Make some adjustments

Refs

https://issues.folio.org/browse/UIDATIMP-1443

Screenshots

@github-actions
Copy link

github-actions bot commented Apr 14, 2023

Jest Unit Test Statistics

       1 files  ±0     207 suites  +1   18m 30s ⏱️ + 2m 47s
1 117 tests +3  1 117 ✔️ +3  0 💤 ±0  0 ±0 
1 128 runs  +3  1 128 ✔️ +3  0 💤 ±0  0 ±0 

Results for commit f31a1ba. ± Comparison against base commit af48d6c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 14, 2023

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit f31a1ba. ± Comparison against base commit af48d6c.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@artem-blazhko artem-blazhko requested a review from a team April 19, 2023 13:22
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

95.3% 95.3% Coverage
0.0% 0.0% Duplication

@mariia-aloshyna
Copy link
Contributor Author

Per @RomanChernetskyi an approach has been changed, so these changes are no longer relevant. Closed the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants