Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIDATIMP-1669: Bump stripes to v9.2.0 for Ramsons #1631

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

OleksandrHladchenko1
Copy link
Contributor

Purpose

Links

UIDATIMP-1669

Copy link

github-actions bot commented Oct 14, 2024

Jest Unit Test Statistics

       1 files  ±0     225 suites  ±0   11m 8s ⏱️ -12s
1 256 tests ±0  1 251 ✔️ ±0  5 💤 ±0  0 ±0 
1 267 runs  ±0  1 262 ✔️ ±0  5 💤 ±0  0 ±0 

Results for commit c916872. ± Comparison against base commit 27c86f5.

♻️ This comment has been updated with latest results.

@mariia-aloshyna mariia-aloshyna requested a review from a team October 14, 2024 13:34
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically bumping a peer is always a breaking change since you are stating a new external requirement. If your tests will pass with stripes-* dev-deps pinned to their stripes v9.1 versions, i.e. this app does not require any of the new features added to stripes in v9.2, you can leave the peer-dep and this repo's major version as-is and this PR is unnecessary.

Alternatively, if you choose to keep the new 9.2.0 requirement in peer-deps, then you need to bump this repo's version from 7.1.8 to 8.0.0.

Copy link

sonarcloud bot commented Oct 17, 2024

@OleksandrHladchenko1
Copy link
Contributor Author

Technically bumping a peer is always a breaking change since you are stating a new external requirement. If your tests will pass with stripes-* dev-deps pinned to their stripes v9.1 versions, i.e. this app does not require any of the new features added to stripes in v9.2, you can leave the peer-dep and this repo's major version as-is and this PR is unnecessary.

Alternatively, if you choose to keep the new 9.2.0 requirement in peer-deps, then you need to bump this repo's version from 7.1.8 to 8.0.0.

Hi @zburke We decided to keep the new 9.2.0 version of stripes in peerDependencies. Therefore we bumped the major version of ui-data-import.

@OleksandrHladchenko1 OleksandrHladchenko1 merged commit 8476180 into master Oct 17, 2024
5 checks passed
@OleksandrHladchenko1 OleksandrHladchenko1 deleted the UIDATIMP-1669 branch October 17, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants