Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rocks): add lib64 plugin directory to package.cpath #1717

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

carbon-steel
Copy link
Contributor

@carbon-steel carbon-steel commented Aug 17, 2024

Description

package.cpath is missing the lib64 directory for plugins that have luarocks dependencies.

Context

I found this issue when I was working on my new Neovim plugin on my Fedora 39 machine. I added the luasockets dependency to rockspec file in my plugin like so:

rockspec_format = "3.0"
package = "typeracer.nvim"
version = "scm-1"
source = {
	url = "git+https://github.com/carbon-steel/typeracer.nvim",
}
dependencies = {
	"luasocket",
}
test_dependencies = {
	"nlua",
}
build = {
	type = "builtin",
	copy_directories = {},
}

I found that the dynamic libraries from the luasockets dependency were installed like so: /home/username/.local/share/nvim/lazy-rocks/typeracer.nvim/lib64/lua/5.1/socket/core.so. However, the only entry related to my plugin typeracer.nvim was: /home/glyph/.local/share/nvim/lazy-rocks/typeracer.nvim/lib/lua/5.1/?.so. The issue is that we only have the plugin's lib directory in package.cpath and not lib64.

I looked through lazy.nvim's code and I think adding the lib64 directory should fix the issue. I don't know if we also want to worry about lib32 as well, but so far, this change works for me.

@carbon-steel carbon-steel changed the title Add lib64 rocks directory to package.cpath fix(rocks): Add lib64 rocks directory to package.cpath Aug 17, 2024
@carbon-steel carbon-steel changed the title fix(rocks): Add lib64 rocks directory to package.cpath fix(rocks): Add lib64 plugin directory to package.cpath Aug 17, 2024
@carbon-steel
Copy link
Contributor Author

I'm not sure how to fix the failing PR title job :/

@folke folke changed the title fix(rocks): Add lib64 plugin directory to package.cpath fix(rocks): add lib64 plugin directory to package.cpath Aug 31, 2024
@folke folke merged commit 80da254 into folke:main Aug 31, 2024
9 of 10 checks passed
@folke
Copy link
Owner

folke commented Aug 31, 2024

ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants