fix(types): missing/wrong types for modal. dropdown, popup, transition

[lubber-de]

Description

Some types fixes to reflect settings in modal, dropdown, popup and transition

Closes

#3081

[lubber-de]

@prudho @KiddoV
Could you please review and test my changes? I was wondering why the original approach always uses confusing definitions like Partial<Pick<DropdownSettings, keyof DropdownSettings>>
which sounds unnecessary as just pointing to "DropdownSettings" should be enough, isn't it?
So for the transition settings in this PR, i just used the simple way and the parser does not complain, so i believe my change is good enough? Perhaps the Pick...keyof syntax is somehow needed?

[KiddoV]

@lubber-de
The use of Partial<Pick<DropdownSettings, keyof DropdownSettings>> is often employed to create a type that represents a subset of DropdownSettings, where all properties are optional. This is useful when you only want to update or provide some fields of the original type while leaving the others with default values.

In your case, if you use DropdownSettings directly, it would require all properties to be provided, which may not be ideal if you only want to specify a few fields and keep the rest at their default values.

I found myself doing something like this a lot:

{
    [...]
    transition: {
        showMethod: "fly left",
        hideMethod: "fly left"
        // I just leave the other fields alone and they will take their default values
    },
}

Using Partial<Pick<DropdownSettings, keyof DropdownSettings>> allows you to specify only the fields you want to change, while the rest remain optional and can default to their initial values.

Take a look at the Toast module:

Fomantic-UI/types/fomantic-ui-toast.d.ts

Line 355 in fb2d8fc

type TransitionSettings = Partial<Pick<Settings.Transition, keyof Settings.Transition>>;

I think you should follow the approach used here... or maybe make TransitionSettings global for all module?

[lubber-de]

@KiddoV Thanks for clarification 👍🏼, i just changed the PR accordingly.

[KiddoV]

This LGTM!