Improve soft-dotted-i check: Add affected languages #4140
Conversation
|
@felipesanches Checks complain about shaperglot, but I don't understand why. Could you please take a look? I can install it on my computer. It may be because the package on PyPI references a git-hosted package, which pip complains about if you install it with explicit version, but passes without explicit version. All very weird. Simon says he'll push an updated package soon. The other complaint is from unrelated changes and are present in the current main codebase, please let us merge this anyway. I already made an issue about that and assigned Marc, who made those changes. But generally, from my side, this is done. |
|
@felipesanches This is ready. Please pay extra attention to the changes in setup.py. There was a merge conflict and this is how I resolved it manually. Maybe you recognize the new setup. Let me know if I shall change anything. Most tests are passing now, except Python 3.8 with an import error that I don't understand. I loosened the protobuf dependency because there was a dependency resolution error earlier probably involving shaperglot. If this is a problem we need to look at the dependencies separately to see if we can tighten or loosen their protobuf. Thank you. |
|
I will only be able to review this later tonight, or tomorrow morning. In the mean time, it would be useful to rebase it all against the main branch, since we had a large commit touching practically all files of the codebase yesterday when we finally adopted the Black code formatter. If you want to, you can rebase it yourself. Otherwise, I can do it once I'm back here. Just let me know what do you prefer. Also, from now on we'll be using black, so it would be good to run |
|
I’m scared. Okay, I will try. If that somehow causes too many conflicts, I’ll make a new branch and PR against the latest main. I’m not the biggest friends with branches and rebasing. |
|
Okay, I committed the blacked changes. Is the rebasing really necessary now when the code of the PR itself is good to go? The branch gets deleted afterwards. I don't get this one. |
| @@ -17,7 +17,7 @@ opentype-sanitizer==9.1.0 | |||
| opentypespec==1.9.1 | |||
| packaging==23.1 | |||
| pip-api==0.0.30 | |||
| protobuf==3.20.3 | |||
| protobuf>=3.19.4 | |||
There was a problem hiding this comment.
please remove this change
| @@ -27,3 +27,4 @@ ufolint==1.2.0 | |||
| unicodedata2==15.0.0 | |||
| vharfbuzz==0.2.0 | |||
| ufo2ft==2.32.0 | |||
| shaperglot>=0.2.0 | |||
There was a problem hiding this comment.
Please always use == on requirements.txt.
And >= only on setup.py, when needed.
| "gflanguages>=0.3.0", # there was an api simplification/update on v0.3.0 (see https://github.com/googlefonts/gflanguages/pull/7) | ||
| "glyphsets>=0.5.0", | ||
| "lxml", | ||
| "munkres", # for interpolation compatibility checking |
There was a problem hiding this comment.
This PR is bringing back all the contents of the setup.py from before a recent commit this week that implemented profile-specific extras. I can fix this one for you in a followup PR, if you are OK with this.
There was a problem hiding this comment.
well... actually not a followup PR, but a new PR to replace this one.
There was a problem hiding this comment.
OK. I will deal with this one today.
|
This continues at #4208 |
Description
This pull request addresses the problems described at issue #4085
PR is in draft because waiting for
shaperglotdependency to appear on PyPI. (cc @simoncozens)To Do
CHANGELOG.md