No open corners check #4809
No open corners check #4809
Conversation
felipesanches
force-pushed
the
no-open-corners-check
branch
from
93c3dfe
to
b1d99fc
Compare
Lib/fontbakery/profiles/ufo.py
Outdated
| "com.google.fonts/check/designspace_has_sources", | ||
| "com.google.fonts/check/designspace_has_default_master", | ||
| "com.google.fonts/check/designspace_has_consistent_glyphset", | ||
| "com.google.fonts/check/designspace_has_consistent_codepoints", | ||
| "com.thetypefounders/check/features_default_languagesystem", | ||
| "com.daltonmaag/check/no_open_corners", |
There was a problem hiding this comment.
To double check - does this not mean that this check will run as part of the UFO profile by default? This is not desirable as most font projects can use open corners without issue, while this check will generate FAILs if it finds open corners
There was a problem hiding this comment.
Also looks like this check might need to be gated behind some feature that pulls in glyphsLib: https://github.com/fonttools/fontbakery/actions/runs/10287022757/job/28469082851?pr=4809#step:6:66
There was a problem hiding this comment.
OK, I'll fix it and I'll also remove the checks from the profile. And later I'll try to address the issue of discoverability for those "orphan" checks. This is probably related to the refactoring suggested at #4801
felipesanches
force-pushed
the
no-open-corners-check
branch
from
b1d99fc
to
468bdce
Compare
* Remove reference to ufo.file_displayname * Add /square to test.ufo * Update changelog & proposal link (PR fonttools#4808)
felipesanches
force-pushed
the
no-open-corners-check
branch
from
468bdce
to
2ae3e07
Compare
(Followup to #4808)