fix: profiles are searched only within package directories

[shetzel]

During package version creation, profiles are only searched within package directories.

@W-13932401@
forcedotcom/cli#2336

[mshanemc]

I'm not sure this would solve the problem completely. Imagine you have several packageDirectories A,B,C that contain profiles.

If you create a PV for A, this would be pulling in profiles from B,C, right?

Maybe this should still take a path to search in (the pkgDir corresponding to what's being packaged) ?

[mshanemc]

If you look at the screenshot on forcedotcom/cli#2336 it's that scenario

[shetzel]

From what I understand, this is the desired behavior. To confirm, we'll need someone from the packaging team to review this.

[mshanemc]

QA: used the https://github.com/mdapi-issues/mre-2gp-unrelated-profiles (always solid repros from @amtrack )

packageProfileApi logs

{"level":30,"time":1695315191755,"name":"sf:PackageProfileApi","msg":"The profile \"Dummy Profile\" from the \"/Users/shane.mclaughlin/eng/repros/mre-2gp-unrelated-profiles/force-app/main/default/profiles/Dummy Profile.profile-meta.xml\" directory was added to this package version."}
{"level":30,"time":1695315191755,"name":"sf:PackageProfileApi","msg":"The \"custom\" profile setting was removed from the \"Dummy Profile\" profile."}
{"level":30,"time":1695315191755,"name":"sf:PackageProfileApi","msg":"The \"userLicense\" profile setting was removed from the \"Dummy Profile\" profile."}
{"level":30,"time":1695315191755,"name":"sf:PackageProfileApi","msg":"The \"userPermissions\" profile setting was removed from the \"Dummy Profile\" profile."}

installed package in an empty scratch org, no obvious issues.