This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Fix https://github.com/forcedotcom/phoenix/issues/577 "DatabaseMetaData ... #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…case sensitive" and forcedotcom#568 "Ensure that the SQL generated for PhoenixDatabaseMetaData.getColumns doesn't allow SQL-injection"
| buf.append(" and " + TABLE_NAME_NAME + " like '" + SchemaUtil.normalizeIdentifier(tableNamePattern) + "'" ); | ||
| } | ||
| pattern(buf, TABLE_SCHEM_NAME, schemaPattern); | ||
| pattern2(buf, TABLE_NAME_NAME, tableNamePattern); |
There was a problem hiding this comment.
Thanks, @julianhyde. Would you mind adding a couple of unit tests to QueryDatabaseMetaDataTest so we make sure we don't regress on these improvements?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...column name searches should be case sensitive" and #568 "Ensure that the SQL generated for PhoenixDatabaseMetaData.getColumns doesn't allow SQL-injection"