New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appropriate functioning of mic button #530

Open

richa208 wants to merge 1 commit into fossasia:master from richa208:mic_button

richa208 commented Jan 18, 2019

Fixes #529

Checklist

I have read the Contribution & Best practices Guide and my PR follows them.
My branch is up-to-date with the Upstream master branch.
The unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

Now after typing any message and sending it, mic button appears as it should have in case of no text in text area.


          appropriate functioning of mic button

fragm3 requested changes

View reviewed changes

Contributor

fragm3 left a comment

Current working is better, if the user input text is empty, we want to show mic only

samagragupta reviewed

View reviewed changes

Member

samagragupta left a comment

I agree with @fragm3

garvitkhandelwal commented Apr 10, 2019

@fragm3 Can you please explain how the current working is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet