Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choosen susi's voice is highlighted. #533

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Choosen susi's voice is highlighted. #533

wants to merge 9 commits into from
+92 −14

Conversation

Puranjay25
Copy link

@Puranjay25 Puranjay25 commented Jan 22, 2019 •
edited
Loading

Fixes #492

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

On submitting the required susi's voice ,the buttons were not being highlighted. Now the selected voice's button is changed to green.

neeraj3029
neeraj3029 approved these changes Feb 19, 2019
View reviewed changes
Copy link
Member

@neeraj3029 neeraj3029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samagragupta
samagragupta suggested changes Mar 16, 2019
View reviewed changes
Copy link
Member

@samagragupta samagragupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash your commits and resolve the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samagragupta samagragupta samagragupta requested changes

@neeraj3029 neeraj3029 neeraj3029 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The chosen susi's voice should be highlighted.
3 participants
@Puranjay25 @neeraj3029 @samagragupta