Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More accessible emails #102

Closed
wants to merge 2 commits into from
Closed

More accessible emails #102

wants to merge 2 commits into from

Conversation

davidpustai
Copy link

Problem

The tables in Inky's generated HTML are purely for styling purposes. For someone using a screen reader it gets really messy to understand the email (video demo).

Solution

Just add the WAI-ARIA role="presentation" to all the generated <table>s.

Solves

foundation/foundation-emails#728

Resources

http://blog.gorebel.com/accessibility-in-email-part-ii/
https://css-tricks.com/html-email-accessibility/#article-header-id-0

@davidpustai
Copy link
Author

@rafibomb Still maintaining this repo in some way? Or is someone else? What do I have to do to get this moving?

I know the tests are failing, but they are at least partially failing because of last commit to v2.2, which is failing too. I was trying to fix it, but couldn't get my head around it. 👶

@davidpustai
Copy link
Author

davidpustai commented Feb 6, 2020

Checks failing due to repo owner name change. Could you restart the build of this PR? cc @garyanikin

@DanielRuf
Copy link
Contributor

Checks failing due to repo owner name change. Could you restart the build of this PR? cc @garyanikin

I will rebase your PR so the CI changes are reflected.

@DanielRuf
Copy link
Contributor

It seems there are several conflicts. Please check and resolve them.

Bildschirmfoto 2020-08-03 um 00 23 05

@nicksiscoe
Copy link

Just bumping this PR because I think it's very important for accessibility! I'm currently using a hacky solution myself in light of this not being the default.

@brianlittmann
Copy link

@nasiscoe — Curious, what is your hacky solution? Agree that merging this PR would be an easy win for accessibility.

@nicksiscoe
Copy link

@nasiscoe — Curious, what is your hacky solution? Agree that merging this PR would be an easy win for accessibility.

I just used a grep command in my build pipeline to manually add role presentation to all built email templates inside the table tag - not as elegant as it being supported out of the box :)

@davidpustai davidpustai closed this by deleting the head repository Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants