Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing signingUrl, define s3Url as optional, updated docs and options to display the content outside the dropzone #44

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

manelpb
Copy link

@manelpb manelpb commented Oct 25, 2017

No description provided.

@cymen
Copy link

cymen commented Oct 27, 2017

Looks good although I eventually realized you can pass signingUrl via the upload prop. For example:

<DropzoneS3Uploader
  ....
  upload={{
    signingUrl: '/s3/xyz',
  }}
/>

The upload prop gets passed down to react-s3-uploader as props.

@manelpb
Copy link
Author

manelpb commented Oct 30, 2017

Sorry about that. I removed the unnecessary prop.

@xpander001
Copy link

Looks good. Any update about this PR?

@emilguareno
Copy link

Any update on this PR? The S3 link will differ between environments and the logic to retrieve it is all in the backend. The URL should be optional. Great library by the way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants