"fix" persistent flags from viper

This can't be the right way to do this, but its the only way I can get the token and factory to be read from a config file or environment w/o cobra missing them. Signed-off-by: Andy Doan <[email protected]>
foundriesio · Sep 12, 2019 · 1c4319a · 1c4319a
1 parent d67f75e
commit 1c4319a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/cmd/root.go b/cmd/root.go
@@ -36,7 +36,6 @@ func init() {
 	rootCmd.PersistentFlags().BoolP("verbose", "v", false, "Print verbose logging")
 
 	rootCmd.PersistentFlags().StringP("token", "t", "", "API token from https://app.foundries.io/settings/tokens/")
-	rootCmd.MarkPersistentFlagRequired("token")
 
 	if err := viper.BindPFlags(rootCmd.PersistentFlags()); err != nil {
 		fmt.Println(err)
@@ -66,6 +65,12 @@ func initConfig() {
 	if viper.GetBool("verbose") {
 		logrus.SetLevel(logrus.DebugLevel)
 	}
+	if len(viper.GetString("token")) == 0 {
+		rootCmd.MarkPersistentFlagRequired("token")
+	}
+	if len(viper.GetString("factory")) == 0 {
+		targetsCmd.MarkPersistentFlagRequired("factory")
+	}
 
 	api = client.NewApiClient("https://api.foundries.io", viper.GetString("token"))
 }
diff --git a/cmd/targets.go b/cmd/targets.go
@@ -16,7 +16,6 @@ var targetsCmd = &cobra.Command{
 func init() {
 	rootCmd.AddCommand(targetsCmd)
 	targetsCmd.PersistentFlags().StringP("factory", "f", "", "Factory to list targets for")
-	targetsCmd.MarkPersistentFlagRequired("factory")
 
 	if err := viper.BindPFlags(targetsCmd.PersistentFlags()); err != nil {
 		fmt.Println(err)