-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for typescript-eslint v6 #48
Conversation
Currently looking for feedback on these changes and whether the following newly enabled rules (which cause a lot of errors in Studio) should be left up to the downstream user to decide whether they want them on or off?
|
I'd be OK leaving these disabled: I would most favor re-enabling For the rest, from the point of view of Console, I think they'd be straightforward to fix in a single PR if we wanted them enabled, but I wouldn't override the defaults to do so; I'd rather keep as close to Studio as possible. |
These two seem possibly useful. The rest not so much. |
fa1af78
to
95314e6
Compare
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@foxglove/eslint-plugin", | |||
"version": "0.23.0", | |||
"version": "1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what a time to be alive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The override choices seem sensible to me, and from the point of view of console (https://github.com/foxglove/console/pull/3900), I'm 👍
Public-Facing Changes
Breaking changes:
plugin:@foxglove/typescript
config to be based on newstrict-type-checked
andstylistic-type-checked
configs from upstreamno-private-identifier
rule (see Add prefer-hash-private rule #46)prefer-hash-private
by defaultDescription
See typescript-eslint v6 release notes: https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/
checkCompoundAssignments: true
is now the default forrestrict-plus-operands
@typescript-eslint/recommended
+@typescript-eslint/recommended-requiring-type-checking
to@typescript-eslint/strict-type-checked
+@typescript-eslint/stylistic-type-checked
prefer-nullish-coalescing
andprefer-optional-chain
are now on by default@typescript-eslint/rule-tester
forRuleTester