Update for typescript-eslint v6

[jtbandes]

Public-Facing Changes

• Update package version to 1.0.0 since the package has been stable for quite a while.

Breaking changes:

• Updated peer and dev dependencies to v6 of typescript-eslint packages
• Updated plugin:@foxglove/typescript config to be based on new strict-type-checked and stylistic-type-checked configs from upstream
  • This adds several new rules that may require disabling or fixing.
• Deleted no-private-identifier rule (see Add prefer-hash-private rule #46)
• Enabled prefer-hash-private by default

Description

See typescript-eslint v6 release notes: https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/

• checkCompoundAssignments: true is now the default for restrict-plus-operands
• Switched from @typescript-eslint/recommended + @typescript-eslint/recommended-requiring-type-checking to @typescript-eslint/strict-type-checked + @typescript-eslint/stylistic-type-checked
  • prefer-nullish-coalescing and prefer-optional-chain are now on by default
• Switched to @typescript-eslint/rule-tester for RuleTester

[jtbandes]

Currently looking for feedback on these changes and whether the following newly enabled rules (which cause a lot of errors in Studio) should be left up to the downstream user to decide whether they want them on or off?

"@typescript-eslint/consistent-type-definitions": off
"@typescript-eslint/consistent-indexed-object-style": off
"@typescript-eslint/consistent-generic-constructors": off
"@typescript-eslint/no-confusing-void-expression": off
"@typescript-eslint/dot-notation": off
"@typescript-eslint/prefer-for-of": off
"@typescript-eslint/no-dynamic-delete": off
"@typescript-eslint/array-type": off
"@typescript-eslint/no-invalid-void-type": off
"@typescript-eslint/no-unsafe-enum-comparison": off
"@typescript-eslint/unified-signatures": off
@typescript-eslint/no-unnecessary-type-arguments
@typescript-eslint/prefer-function-type
@typescript-eslint/no-redundant-type-constituents
@typescript-eslint/no-base-to-string
@typescript-eslint/prefer-nullish-coalescing
@typescript-eslint/prefer-optional-chain (think we already had this but it catches more cases now)
@typescript-eslint/prefer-reduce-type-parameter
@typescript-eslint/no-throw-literal
@typescript-eslint/prefer-string-starts-ends-with
@typescript-eslint/non-nullable-type-assertion-style

[bryfox]

Currently looking for feedback on these changes

I'd be OK leaving these disabled: no-base-to-string and prefer-nullish-coalescing seemed to cause false positives; consistent-type-definitions, array-type, and perhaps prefer-optional-chain can (IMO) harm readability and/or IDE usability.

I would most favor re-enabling no-unsafe-enum-comparison and no-throw-literal.

For the rest, from the point of view of Console, I think they'd be straightforward to fix in a single PR if we wanted them enabled, but I wouldn't override the defaults to do so; I'd rather keep as close to Studio as possible.

[foxymiles]

consistent-type-definitions
consistent-indexed-object-style
consistent-generic-constructors
no-confusing-void-expression
dot-notation
prefer-for-of
no-dynamic-delete
array-type
no-invalid-void-type
no-unsafe-enum-comparison
unified-signatures
no-unnecessary-type-arguments
prefer-function-type
no-redundant-type-constituents
no-base-to-string
prefer-nullish-coalescing
prefer-optional-chain
prefer-reduce-type-parameter
no-throw-literal
prefer-string-starts-ends-with
non-nullable-type-assertion-style

Rules for reference

[foxymiles]

no-confusing-void-expression

no-invalid-void-type

These two seem possibly useful. The rest not so much.

[amacneil]

what a time to be alive

[bryfox]

The override choices seem sensible to me, and from the point of view of console (https://github.com/foxglove/console/pull/3900), I'm 👍