Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce autoscalers for inbox listener and stream service #18

Closed
wants to merge 4 commits into from
Closed

Introduce autoscalers for inbox listener and stream service #18

wants to merge 4 commits into from

Commits on Jan 11, 2023

  1. Add autoscalers for inbox-listener and stream service 

    Adds autoscalers for the inbox-listener and stream service. The inbox
listener autoscaler relies on KEDA. The stream service autoscaler is a
standard HPA.

KEDA has some unfortunate friction with helm. It cannot be added as a
dependency to the chart and installed in a reasonable way, because it
relies on CRDs, which helm will not be responsible for updating or
installing in order.

Based on conversation in kedacore/charts#226,
there are two alternative approaches open to us:

* We can instruct users to install KEDA on their cluster prior to
  installing our deployment. The command for this is,
    helm install keda --version 2.9.1 --namespace keda kedacore/keda --create-namespace

* We can vendor KEDA's CRDs and put them into our chart, under a crd
  directory. This should enable a single-command install, but comes with
  the downsides that,
  1. Helm will not update or manage the keda CRDs for us
  2. If users already have KEDA installed (certainly possible) we will
     encounter a conflict.

  Mainly due to the second item, this PR takes the first approach.
    @wkalt
    wkalt committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    16f3804 View commit details
    Browse the repository at this point in the history

  2. Templatize names of deployments

    @wkalt
    wkalt committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    142b305 View commit details
    Browse the repository at this point in the history

  3. Move GOOGLE_APPLICATION_CREDENTIALS into user-supplied config 

    This allows alternative mechanisms for GCP auth to be used, for instance
the minikube gcp-auth plugin.
    @wkalt
    wkalt committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    daf709d View commit details
    Browse the repository at this point in the history

  4. Restructure templates directory 

    Restructures the templates directory so-as not to suggest that every
resource type be under a dedicated folder. In most cases we just have
one instance of these resource types, and creating separate directories
for e.g scaled object seems like overkill.
    @wkalt
    wkalt committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    26903e9 View commit details
    Browse the repository at this point in the history