Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primary-site: add KEDA based autoscaling support to inbox-listener #92

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

sofuture
Copy link
Contributor

@sofuture sofuture commented Aug 22, 2024

Changelog

  • Feature: add support for built-in inbox-listener autoscaling, see documentation for details

Docs

https://docs.foxglove.dev/docs/primary-sites/self-hosting/autoscaling#inbox-listener

Description

Autoscaling can now be enabled automatically for inbox-listener. Requires KEDA to be installed as a prerequisite.

BeforeAfter

Fixes: FG-8702
Fixes: FG-7045
Fixes: FG-8694

@sofuture sofuture marked this pull request as ready for review August 26, 2024 15:26
Copy link
Contributor

@bryfox bryfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this include autoscaling config for the stream service as well?

autoscaling:
enabled: false
minReplicas: 1
maxReplicas: 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these recommended values? Do we have any way to make recommendations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on load and capacity, so we'll have to expound on this in docs. False and 1 are appropriate defaults in any case.

@sofuture sofuture changed the title add KEDA based autoscaling support primary-site: add KEDA based autoscaling support to inbox-listener Sep 5, 2024
@defunctzombie defunctzombie removed their request for review September 10, 2024 02:08
@sofuture
Copy link
Contributor Author

@james-rms this is ready to go, there was no way to improve the KEDA install.

Copy link

linear bot commented Sep 12, 2024

@sofuture sofuture merged commit 5851da6 into main Sep 12, 2024
1 check passed
@sofuture sofuture deleted the jz/with-autoscaling branch September 12, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants