Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary site: release v0.0.46 #94

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Primary site: release v0.0.46 #94

merged 2 commits into from
Sep 11, 2024

Conversation

james-rms
Copy link
Contributor

Changelog

  • Added: support for downloading quarantined pending imports. This feature will be enabled through the UI in the near future.
    • Note: For this to work, deployers will need to double-check permissions on their inbox bucket to make sure that their stream service has access to read from them.
  • Added: support for retrying quarantined pending imports. This feature will be enabled through the UI in the near future.
  • Fixed: if the garbage collector cannot delete a temp file, it will log an error instead of aborting.
  • Fixed: the request ID tag in inbox listener logs now matches the request ID in the foxglove API for pending imports.
  • Fixed: various corrupt BAG and MCAP errors will now result in the file being quarantined immediately rather than retrying 3 times.

Docs

Description

BeforeAfter

Copy link
Contributor

@bryfox bryfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deployers will need to double-check permissions on their inbox bucket to make sure that their stream service has access to read from them

It seems like the call-out should be stronger than this. IIUC, this change will modify the IAM grants to their inbox, and we don't make that optional. (Is that right? What could fail that requires double-checking?) Or maybe this is fine and we can be more specific in the public release notes.

@james-rms
Copy link
Contributor Author

This helm chart doesn't control IAM grants, that's done by the deployer (with terraform or with a mouse and keyboard).

So far we don't plan to make this functionality permanently optional, if we did I'd prefer to make it optional at the control plane level and leave the functionality running in the stream service either way.

@james-rms
Copy link
Contributor Author

I'm going to release this now to get the bug fixes now, and delay documenting these details in release notes until we're aligned.

@james-rms james-rms merged commit cab6f77 into main Sep 11, 2024
1 check passed
@james-rms james-rms deleted the jrms/primary-site-46 branch September 11, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants