show durations and published date on the video thumbnails #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the pull request brother. I would like to request you to allow me some time (2 weeks) to complete my current refactoring on the server side (making genric repo thing). then i can accept this PR. Thanks 🙏 |
|
@aninda052 please have a look |
aninda052
added a commit
to aninda052/mern-video-streaming
that referenced
this pull request
Aug 2, 2023
|
@aninda052 please resolve the conflicts.. thanks 👍 |
aninda052
force-pushed
the
feature/video-durations
branch
from
1e4c2a5
to
357a3be
Compare
@foyzulkarim conflict resolve |
|
what is the difference between this work and #47 ? either use different code in different PR, or close either of the PR please. |
|
closing this pr as i already merge feature/video-durations (#48) into feature/update-video-status (#47) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr will close multiple issues -
close #28
ffprobepackage for getting video metadata@ffprobe-installer/ffprobefor platform independent binary installerdurationsfiled invideoscollection to store video durations in seconddurationsin seconds usingffprobeand store that while storing video info in dbreact-momentpackage to format(HH:mm:ss) videodurations.close #29
recordingDateas published date in video thumbnails.react-momentpackage to format(DD/MM/yyyy)recordingDate.