Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update video status to published when processing is finished #47

Merged
merged 34 commits into from
Aug 7, 2023
Merged

update video status to published when processing is finished #47

merged 34 commits into from
Aug 7, 2023

Conversation

aninda052
Copy link
Contributor

@aninda052 aninda052 commented Jul 26, 2023 •
edited
Loading

This pr will close #46.

  • Add a new filed status in videos collection for tracking video status.
  • set status filed as database index filed.
  • Set pending as status while user upload a new video.
  • After video converted to HLS format, set status to published.

This pr will also merge #48

@aninda052 aninda052 changed the title update video status to published when processing is finished (#46) update video status to published when processing is finished Jul 26, 2023
@foyzulkarim
Copy link
Owner

thanks for the pull request brother. I would like to request you to allow me some time (2 weeks) to complete my current refactoring on the server side (making genric repo thing). then i can accept this PR. Thanks 🙏

@foyzulkarim
Copy link
Owner

Conflicts. 🔢

foyzulkarim and others added 21 commits August 3, 2023 17:33
@foyzulkarim @aninda052
Update mongo usage and create Singleton MongoManager
7863c51
@foyzulkarim @aninda052
Refactor mongo schema update to run centrally
238122f
@foyzulkarim @aninda052
before implementing generic repository
ea5731c
@foyzulkarim @aninda052
Work in progress
58d0446
@foyzulkarim @aninda052
getById is moved to common place
9eb728b
@foyzulkarim @aninda052
Implemented generic searching
8d3b1f1
@aninda052
Merge branch 'main' into feature/update-video-status
51278ec
@aninda052
chore : add ffprobe package for getting video metadata (foyzulkarim#28
3d56a9c 
)
@aninda052
feat: store video durations while uploading a video (foyzulkarim#28)
979e041
@aninda052
doc : add comment for getVideoDurations (foyzulkarim#28)
d3ec0ee
@aninda052
refactor: rename "product" to "video" (foyzulkarim#28)
37ca124
@aninda052
chore : add "react-moment" library (foyzulkarim#28)
5149cf4
@aninda052
feat : show duration on video thumbnails (foyzulkarim#28)
52e94da
@aninda052
feat : show recordingDate on video thumbnails (foyzulkarim#29)
57ee4b9
@aninda052
stype : video thumbnails design improvment (foyzulkarim#29)
7cc8194
@foyzulkarim @aninda052
Update mongo usage and create Singleton MongoManager
a45e3a9
@foyzulkarim @aninda052
Refactor mongo schema update to run centrally
9d4f013
@foyzulkarim @aninda052
before implementing generic repository
799c261
@foyzulkarim @aninda052
Work in progress
953c275
@foyzulkarim @aninda052
getById is moved to common place
4bac583
@foyzulkarim @aninda052
Implemented generic searching
a0deced
@aninda052
Copy link
Contributor Author

@foyzulkarim conflicts resolve

foyzulkarim
foyzulkarim requested changes Aug 5, 2023
View reviewed changes
Copy link
Owner

@foyzulkarim foyzulkarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @aninda052
i have added some suggestions

@foyzulkarim
Copy link
Owner

when you complete your changes, please use the label ready for review

@foyzulkarim foyzulkarim mentioned this pull request Aug 5, 2023
Closed
@aninda052
Copy link
Contributor Author

when you complete your changes, please use the label ready for review

@foyzulkarim vai, i do not have permission to set any label

foyzulkarim
foyzulkarim approved these changes Aug 7, 2023
View reviewed changes
Copy link
Owner

@foyzulkarim foyzulkarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was a massive piece of work @aninda052 and you did a great job. 👏

@foyzulkarim foyzulkarim merged commit 1eb0fc3 into foyzulkarim:main Aug 7, 2023
@aninda052 aninda052 deleted the feature/update-video-status branch August 7, 2023 14:43
This was referenced Aug 7, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foyzulkarim foyzulkarim foyzulkarim approved these changes

Assignees

@aninda052 aninda052

Labels
None yet
Projects
MERN Video Streaming
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update video status to published when processing is finished
2 participants
@aninda052 @foyzulkarim