Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture recent output for nicer error messages #4

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

snoyberg
Copy link
Member

This will include recent output in the Slack error messages.

This will include recent output in the Slack error messages.
@snoyberg snoyberg requested a review from psibi June 13, 2024 10:58
Copy link
Member

@psibi psibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@snoyberg snoyberg merged commit b7c44fc into main Jun 13, 2024
7 checks passed
@snoyberg snoyberg deleted the capture-recent-output branch June 13, 2024 11:32
@snoyberg
Copy link
Member Author

Do I need to do any other changes to prepare for a release so we can use this?

@psibi
Copy link
Member

psibi commented Jun 13, 2024

@snoyberg You can tag a new release and push it, that should build a new binary (eg: https://github.com/fpco/health-check/releases/tag/v0.1.0) . We should then use the new binaries in our docker image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants