Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getPid #79

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Add getPid #79

merged 1 commit into from
Aug 17, 2024

Conversation

9999years
Copy link
Contributor

This allows fetching a process' ID without using unsafeProcessHandle.

@tomjaguarpaw
Copy link
Collaborator

Seems pretty reasonable to me. @snoyberg, if you don't object then I'll merge.

snoyberg
snoyberg approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection from me.

@tomjaguarpaw
Copy link
Collaborator

The failures on Windows are genuine: there the PID has a different type. @9999years, what would you like to do?

@tomjaguarpaw
Copy link
Collaborator

Please rebase on master to pick up some CI fixes.

@tomjaguarpaw
Copy link
Collaborator

The failures on Windows are genuine: there the PID has a different type. @9999years, what would you like to do?

Oh, the solution is to use Pid (which is a system-dependent type synonym) rather than ProcessId. @9999years, please make the change.

@9999years
Copy link
Contributor Author

Oh, the solution is to use Pid

Done, PTAL

@9999years @tomjaguarpaw
Add getPid
564b2f8 
This allows fetching a process' ID without using `unsafeProcessHandle`.
@tomjaguarpaw
Copy link
Collaborator

I took the liberty of pushing a commit removing an unused import (I'm not sure why CI doesn't warn about unused imports. Perhaps there's some stack setting I should configure).

@tomjaguarpaw tomjaguarpaw merged commit de19b4e into fpco:master Aug 17, 2024
23 checks passed
@tomjaguarpaw
Copy link
Collaborator

Thank you!

@9999years 9999years deleted the add-getpid branch August 19, 2024 16:36
@tomjaguarpaw
Copy link
Collaborator

This has been released in https://hackage.haskell.org/package/typed-process-0.2.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg snoyberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@9999years @tomjaguarpaw @snoyberg