[WIP] conditional compilation around at_fdcwd , at_symlink_follow #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoyberg
requested changes
May 7, 2021
| @@ -22,6 +22,11 @@ extra-source-files: | |||
| README.md | |||
| ChangeLog.md | |||
|
|
|||
| flag old-glibc | |||
| description: compile with post-2016 glibc, allowing atomic file writes | |||
There was a problem hiding this comment.
Looks like the logic is reversed here. This flag seems to enable the old glibc.
| flag old-glibc | ||
| description: compile with post-2016 glibc, allowing atomic file writes | ||
| default: False | ||
| manual: False |
There was a problem hiding this comment.
This should be manual: True, right? We don't want the dep solver trying to change this flag.
| @@ -89,7 +89,7 @@ import Data.ByteString as B (ByteString, writeFile) | |||
| import Control.Monad.IO.Unlift | |||
| import UnliftIO.IO (Handle, IOMode(..), withBinaryFile) | |||
|
|
|||
| #if WINDOWS | |||
| #if (WINDOWS || OLD-GLIBC) | |||
There was a problem hiding this comment.
It would be nice to have some kind of a changelog entry explaining this change and what the impact of enabling the flag would be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Mac OSX, with an old XCode and glibc, unliftio doesn't compile :( ( #59 ).
I've tried adding a build flag around the problem but I can't get it to propagate down to GCC.
I understand supporting old systems might not be high in priority but I figured a change along these lines would be minimally disruptive (and allow me to use unliftio on my janky old laptop!)
Looking forward to all feedback.