Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Drop redis_socketio service #1382

Merged
merged 2 commits into from
Aug 7, 2023

Commits on Nov 2, 2022

  1. refactor!: Reuse redis_cache instace for socketio

    WARNING: Just a POC. You're free to modify your setup to test this out.
    
    Summary:
    - After this change bench wont generate config for redis_socketio
      instance.
    - Instead we set the same port as redis_cache service for use in
      socketio. i.e. both will share same instance.
    
    Code changes:
    
    - Config will have this difference:
    
    ```diff
    - "redis_socketio": "redis://localhost:12000",
    - "redis_cache": "redis://localhost:13000",
    + "redis_socketio": "redis://localhost:13000",
    + "redis_cache": "redis://localhost:13000",
    ```
    
    - supervisord/systemd wont start redis_socketio service
    - for development setups: redis_socketio service is removed from procfile.
    
    Why?
    
    - Currently this redis instance is used only to ship messages from python
    to nodejs server... which is largely stateless (only pub/sub channels)
    - This change reduces 1 running process. Less resources for this ~= more
      resources for other running things.
    
    TODO:
    - [ ] decicisions - should we even do this? this should be optinal?
    - [ ] refactor progressbar in frappe
    - [ ] Tests - manual, FC, docker, automated
    - [ ] "migration" plan
    
    All dependent deployment projects will likely have to refactor their code to drop this service, shouldn't be too much work.
    Example: Frappe cloud, Frappe Docker.
    ankush committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    a172b14 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Configuration menu
    Copy the full SHA
    2a41815 View commit details
    Browse the repository at this point in the history