refactor(treewide): use mariadb commands and service instead of mysql
#1489
Conversation
bench/commands/setup.py
Outdated
| @@ -358,7 +358,7 @@ def sync_domains(domain=None, site=None): | |||
| @click.command("role", help="Install dependencies via ansible roles") | |||
| @click.argument("role") | |||
| @click.option("--admin_emails", default="") | |||
| @click.option("--mysql_root_password") | |||
| @click.option("--mariadb_root_password") | |||
There was a problem hiding this comment.
We shouldn't change this, this can be breaking change for some scripts.
Add another alias for same flag? IIRC click does support that.
There was a problem hiding this comment.
Ah cool, will do that.
Wanted to ask anyway, there's a lot of reference to MySQL in general in a few places like this, so for now should we leave them as-is or add secondary option with mariadb like this?
There was a problem hiding this comment.
Added as aliases. Left variable names and dict keys intact so that it won't cause any issues.
akhilnarang
force-pushed
the
mysql-to-mariadb
branch
from
ede7609
to
9a9252e
Compare
…sql` Signed-off-by: Akhil Narang <[email protected]>
akhilnarang
force-pushed
the
mysql-to-mariadb
branch
from
9a9252e
to
8f3f1a4
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 5.18.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
refactor: use
mariadbcommands and service instead ofmysqlThis resolves #1472
This has been done because the mysql command issues a deprecation warning now
mysql: Deprecated program name. It will be removed in a future release, use '/usr/bin/mariadb' instead