fix: delete node_modules if frappe supports app_cache

[18alantom]

Since part of the build executes in frappe, get-app cache requires at least v15.12.0 of frappe to function optimally i.e. delete node_modules and skip build. This PR checks frappe version mentioned in the app's pyproject.toml.

Uses version specifier format mentioned in: #1524

[ankush]

@18alantom just few steps away from closing linked issue, might as well complete it 😬

[18alantom]

@18alantom just few steps away from closing linked issue, might as well complete it 😬

@ankush I'm unsure about what all needs to be done w.r.t the linked issue:

• How should dependency absence be handled, fail get-app or just show a warning?
• Assuming frappe-dependencies are runtime, i.e. get-app can still run without the frappe-dependencies, doesn't make sense to fail it.
• Any way to indicate strict requirement during get-app, (in case setup.py needs the dependency).

If we're looking to fail get-apps if mentioned dependency is not present, we should hold off until more thought is given. Press Deploy Candidate app ordering too would have to be updated to account for it.

[ankush]

Yes we should fail with non-zero exit code.

If ordering is a hard problem to solve we can optionally add a check command to do it after all apps are installed on bench?

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[18alantom]

Added dependency check, fails if folder not present. Also added a version check, doesn't fail but gives a warning if mismatch.

Regarding ordering:

1. Ordering needs to be managed by whomever is installing apps using bench.
2. If (all) apps have frappe-dependencies mentioned, invalid ordering is not possible (cause it will fail).
3. If apps do not have frappe-dependencies mentioned, invalid ordering cannot be prevented (else get-app breaks).
4. By point 2. and 3. ordering check in bench is redundant.

[github-actions]

🎉 This PR is included in version 5.21.1 🎉

The release is available on:

• GitHub release
• v5.21.1

Your semantic-release bot 📦🚀